KEMBAR78

Fixed DatePicker's DateSelected event not firing on Windows - NET 10 Preview 6 by Dhivya-SF4094 · Pull Request #30748 · dotnet/maui · GitHub

Fixed DatePicker's DateSelected event not firing on Windows - NET 10 Preview 6 #30748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jfversluis merged 4 commits into dotnet:net10.0 from Dhivya-SF4094:fix-30736

Aug 18, 2025

+60 −6

Contributor

Dhivya-SF4094 commented Jul 22, 2025 •

edited

Loading

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue detail:

DatePicker's DateSelected event not firing on Windows - .NET 10 Preview 6

Root Cause

The DateSelected event was not firing on Windows due to an incorrect condition check. The original code used if (VirtualView.Date is null), which did not properly capture changes to the selected date. Although Date can be set to null, the check was not sufficient to determine whether the date had actually changed. As a result, the selected date was not updated, and the event was not triggered.

Description of Change

To resolve these issues, the condition was updated to if (VirtualView.Date != args.NewDate.Value.DateTime) to ensure the event triggers only when the selected date actually changes.

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Issues Fixed:

Fixes #30736

Screenshots

Before	After
30736_BeforeFix.mp4	30736_AfterFix.mp4

dotnet-policy-service bot added community ✨ partner/syncfusion labels

jsuarezruiz added the area-controls-datetimepicker label

Contributor

jsuarezruiz commented Jul 22, 2025

/azp run

azure-pipelines bot commented Jul 22, 2025

Azure Pipelines successfully started running 3 pipeline(s).

Dhivya-SF4094 marked this pull request as ready for review

July 23, 2025 07:50

Copilot AI review requested due to automatic review settings

July 23, 2025 07:50

Dhivya-SF4094 requested a review from a team as a code owner

July 23, 2025 07:50

Dhivya-SF4094 requested review from mattleibow and rmarinho

July 23, 2025 07:50

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull Request Overview

This PR fixes a bug where the DatePicker's DateSelected event was not firing on Windows in .NET 10 Preview 6. The issue was caused by an incorrect null check condition that prevented the event from being triggered when the date changed.

Fixed the conditional logic in DatePickerHandler.Windows.cs to properly detect date changes
Added comprehensive device tests to verify the DateSelected event fires across all platforms
Removed unnecessary access modifier from the DateChanged method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
src/Core/src/Handlers/DatePicker/DatePickerHandler.Windows.cs	Fixed condition check from null comparison to actual date comparison and cleaned up method signature
src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs	Added comprehensive test coverage for DateSelected event firing across all platforms

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

Comment on lines 54 to 138

    
                              if (handler.DatePickerDialog != null)

                              {

                                  handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);

                              }

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

      
                            if (handler.DatePickerDialog != null)
          
                            {
          
                                handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);
          
                            }
          
            			if (handler.DatePickerDialog != null)
          
            			{
          
            				handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);
          
            			}

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

    
              #elif IOS

                              if (handler.DatePickerDialog != null)

                              {

                                  handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

      
                                handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);
          
            			handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

    
                              if (handler.DatePickerDialog != null)

                              {

                                  handler.DatePickerDialog.SetDate(newDate.ToNSDate(), false);

                              }

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

Comment on lines +59 to +143

    
                              if (handler.PlatformView != null)

                              {

                                  handler.PlatformView.Date = newDate;

                              }

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

      
                            if (handler.PlatformView != null)
          
                            {
          
                                handler.PlatformView.Date = newDate;
          
                            }
          
            			if (handler.PlatformView != null)
          
            			{
          
            				handler.PlatformView.Date = newDate;
          
            			}

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

    
              #elif WINDOWS

                              if (handler.PlatformView != null)

                              {

                                  handler.PlatformView.Date = newDate;

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

      
                                handler.PlatformView.Date = newDate;
          
            			handler.PlatformView.Date = newDate;

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs

    
                              if (handler.PlatformView != null)

                              {

                                  handler.PlatformView.Date = newDate;

                              }

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line uses spaces while the surrounding code uses tabs. Please maintain consistent indentation throughout the file.

Suggested change

Copilot uses AI. Check for mistakes.

src/Controls/tests/DeviceTests/Elements/DatePicker/DatePickerTests.cs Outdated

    
                                  handler.PlatformView.Date = newDate;

                              }

              #elif MACCATALYST

              	 handler.PlatformView.Date = newDate.ToNSDate();

Copilot AI Jul 23, 2025

Inconsistent indentation detected. This line has an extra space before the tab character. Please maintain consistent indentation throughout the file.

Suggested change

      
            	 handler.PlatformView.Date = newDate.ToNSDate();
          
            		handler.PlatformView.Date = newDate.ToNSDate();

Copilot uses AI. Check for mistakes.

jfversluis added this to the .NET 10 SR1 milestone

Member

jfversluis commented Aug 7, 2025 •

edited

Loading

The original code used if (VirtualView.Date is null), which was always false since Date is a non-nullable DateTime

This is not entirely true. A change we made in .NET 10 is to make the Date property nullable. Can you please double check (and add a test) to make sure it works with both a different value and null?

Also please resolve the conflicts and address the feedback.

jfversluis requested changes

View reviewed changes

Member

jfversluis left a comment

See above

Dhivya-SF4094 force-pushed the fix-30736 branch from e28a932 to 0593d78 Compare

August 7, 2025 13:16

Contributor Author

Dhivya-SF4094 commented Aug 7, 2025

The original code used if (VirtualView.Date is null), which was always false since Date is a non-nullable DateTime

This is not entirely true. A change we made in .NET 10 is to make the Date property nullable. Can you please double check (and add a test) to make sure it works with both a different value and null?

Also please resolve the conflicts and address the feedback.

@jfversluis I have updated the PR description to reflect that the Date property is nullable in .NET 10. I also verified that the fix correctly checks whether the new date differs from the existing one before firing the DateSelected event.

attempted to add a test case that sets the Date to null, but it currently throws an exception. This issue will be handled in a separate PR, and a subsequent test case would be added in the same PR.

Member

jfversluis commented Aug 15, 2025

@Dhivya-SF4094 Can you resolve the conflict please? :)

Dhivya-SF4094 added 2 commits

August 16, 2025 09:47


          Fixed DatePicker's DateSelected event not firing on Windows - .NET 10…

dc003ca

… Preview 6


          Updated test sample

2559fb3

Dhivya-SF4094 force-pushed the fix-30736 branch from 0593d78 to 2559fb3 Compare

August 16, 2025 04:18


          Fixed DatePicker's DateSelected event not firing on Windows - .NET 10…

afcd64c

… Preview 6

Dhivya-SF4094 force-pushed the fix-30736 branch from 2559fb3 to afcd64c Compare

August 16, 2025 05:57


          Added empty line

ac7cfdc

Contributor Author

Dhivya-SF4094 commented Aug 16, 2025

@Dhivya-SF4094 Can you resolve the conflict please? :)

Conflicts has been resolved.

jfversluis modified the milestones: .NET 10 SR1, .NET 10.0-rc1

Member

jfversluis commented Aug 18, 2025

/azp run

azure-pipelines bot commented Aug 18, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis approved these changes

View reviewed changes

Member

jfversluis left a comment

See above

jfversluis merged commit b104fe1 into dotnet:net10.0

129 checks passed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

jfversluis jfversluis approved these changes

mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

Labels

area-controls-datetimepicker community ✨ partner/syncfusion