KEMBAR78
[NET 10/ WinUI] Open item template context by pictos · Pull Request #30852 · dotnet/maui · GitHub
Skip to content

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Jul 26, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This class holds all information needed between the platform ListViewItem and CollectionView (Maui). Opening this type will allow devs (app/libs) to easily access data from CollectionViewHandler and access, as well, the Maui's ItemTemplate.

Description of Change

Issues Fixed

Related to #30762

@Copilot Copilot AI review requested due to automatic review settings July 26, 2025 01:11
@pictos pictos requested a review from a team as a code owner July 26, 2025 01:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the ItemTemplateContext class public to enable developers to access data from CollectionViewHandler and work with Maui's ItemTemplate. The change exposes a previously internal class that holds information needed between the platform ListViewItem and CollectionView.

  • Changes ItemTemplateContext class visibility from internal to public
  • Keeps the constructor internal to maintain controlled instantiation
  • Updates public API surface to reflect the new public members

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ItemTemplateContext.cs Changes class visibility from internal to public while keeping constructor internal
PublicAPI.Unshipped.txt Adds new public API surface entries for the exposed ItemTemplateContext class and its properties

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 26, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 10.0-rc1 milestone Aug 13, 2025
@PureWeen PureWeen moved this from Todo to Changes Requested in MAUI SDK Ongoing Aug 13, 2025
@PureWeen
Copy link
Member

unshipped apis need to be updated

@PureWeen
Copy link
Member

/rebase

# Conflicts:
#	src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt
@github-actions github-actions bot force-pushed the open-ItemTemplateContext-net10 branch from f94599b to 5704dc2 Compare August 13, 2025 16:59
@PureWeen
Copy link
Member

/azp run

PureWeen
PureWeen previously approved these changes Aug 13, 2025
@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in MAUI SDK Ongoing Aug 13, 2025
@PureWeen PureWeen added the p/0 Work that we can't release without label Aug 13, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

  • failing tests unrelated

@PureWeen PureWeen merged commit 8025b56 into dotnet:net10.0 Aug 15, 2025
120 of 129 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Aug 15, 2025
@pictos pictos deleted the open-ItemTemplateContext-net10 branch August 15, 2025 18:52
@PureWeen PureWeen added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Aug 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution p/0 Work that we can't release without platform/windows

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants