-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[NET 10/ WinUI] Open item template context #30852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET 10/ WinUI] Open item template context #30852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the ItemTemplateContext class public to enable developers to access data from CollectionViewHandler and work with Maui's ItemTemplate. The change exposes a previously internal class that holds information needed between the platform ListViewItem and CollectionView.
- Changes
ItemTemplateContextclass visibility from internal to public - Keeps the constructor internal to maintain controlled instantiation
- Updates public API surface to reflect the new public members
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ItemTemplateContext.cs | Changes class visibility from internal to public while keeping constructor internal |
| PublicAPI.Unshipped.txt | Adds new public API surface entries for the exposed ItemTemplateContext class and its properties |
src/Controls/src/Core/Platform/Windows/CollectionView/ItemTemplateContext.cs
Show resolved
Hide resolved
|
Hey there @@pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
unshipped apis need to be updated |
|
/rebase |
# Conflicts: # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt
f94599b to
5704dc2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
This class holds all information needed between the platform
ListViewItemandCollectionView(Maui). Opening this type will allow devs (app/libs) to easily access data fromCollectionViewHandlerand access, as well, the Maui'sItemTemplate.Description of Change
Issues Fixed
Related to #30762