KEMBAR78
[SG] Decorate generated types with [Generated] by StephaneDelcroix · Pull Request #30903 · dotnet/maui · GitHub
Skip to content

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

some types are 100% generated (for xaml-only resourcedictionaries). They should cause documentation to be generated, so mark them as [Generated]

Issues Fixed

some types are 100% generated (for xaml-only resourcedictionaries). They
should cause documentation to be generated, so mark them as [Generated]

- fixes #27911
- closes #30259
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 10:57
@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner July 29, 2025 10:57
@StephaneDelcroix StephaneDelcroix changed the title [SG] Decorate geneated types with [Generated] [SG] Decorate generated types with [Generated] Jul 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the [GeneratedCode] attribute to mark generated partial classes as generated code in XAML source generation. This ensures that 100% generated types (like XAML-only resource dictionaries) are properly decorated to exclude them from documentation generation and code analysis.

  • Adds [GeneratedCode] attribute to generated partial classes when a default constructor is being generated
  • Uses Microsoft.Maui.Controls.SourceGen as the tool name with version 1.0.0.0

@StephaneDelcroix StephaneDelcroix enabled auto-merge (squash) July 29, 2025 10:59
@StephaneDelcroix StephaneDelcroix merged commit 7c7d51c into net10.0 Jul 29, 2025
1 of 34 checks passed
@StephaneDelcroix StephaneDelcroix deleted the dev/stdelc/fix27911 branch July 29, 2025 11:03
@jfversluis
Copy link
Member

/backport to 10.0.1xx-preview7

@github-actions
Copy link
Contributor

Started backporting to 10.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/16597440913

@github-actions
Copy link
Contributor

@jfversluis an error occurred while backporting to "10.0.1xx-preview7", please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@github-actions
Copy link
Contributor

Started backporting to 10.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/16597440913

@github-actions
Copy link
Contributor

@jfversluis an error occurred while backporting to "10.0.1xx-preview7", please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@jfversluis
Copy link
Member

/backport to release/10.0.1xx-preview7

@github-actions
Copy link
Contributor

Started backporting to release/10.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/16597591472

@PureWeen PureWeen added the area-xaml XAML, CSS, Triggers, Behaviors label Aug 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-xaml XAML, CSS, Triggers, Behaviors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants