KEMBAR78
[android] update AOT profile for .NET 10 RC 1 by jonathanpeppers · Pull Request #31187 · dotnet/maui · GitHub
Skip to content

Conversation

@jonathanpeppers
Copy link
Member

I tested this with a "franken-build", using System.Private.CoreLib.dll from this PR:

With the Type.GetType() revert in place for Mono, I'm getting good startup on an Android Pixel 5 (old) device with the dotnet new maui project template:

Comparing the updated AOT profile:

Before:
Average(ms): 624.9
Std Err(ms): 3.77844765302719
Std Dev(ms): 11.9485006032835
After:
Average(ms): 582.1
Std Err(ms): 2.92289810519172
Std Dev(ms): 9.24301538099625

Some of my past numbers were on a Pixel 7, so these are good numbers for an even older device.

We may want to run this again with newer (less-franken!) builds, but this is worth merging for now.

@jonathanpeppers jonathanpeppers added this to the .NET 10.0-rc1 milestone Aug 15, 2025
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 16:38
@jonathanpeppers jonathanpeppers requested a review from a team as a code owner August 15, 2025 16:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@rmarinho
Copy link
Member

I just merged RC1 changes for sdk and runtime , should we rebase and recreate ?

@rmarinho
Copy link
Member

/rebase

I tested this with a "franken-build", using
`System.Private.CoreLib.dll` from this PR:

* dotnet/runtime#118761

With the `Type.GetType()` revert in place for Mono, I'm getting good
startup on an Android Pixel 5 (old) device with the `dotnet new maui`
project template:

Comparing the updated AOT profile:

    Before:
    Average(ms): 624.9
    Std Err(ms): 3.77844765302719
    Std Dev(ms): 11.9485006032835
    After:
    Average(ms): 582.1
    Std Err(ms): 2.92289810519172
    Std Dev(ms): 9.24301538099625

Some of my past numbers were on a Pixel 7, so these are good numbers for
an even older device.

We may want to run this again with newer (less-franken) builds, but
this is worth merging for now.
@github-actions github-actions bot force-pushed the dev/peppers/net10rc1-aotprofile branch from d6b0094 to d0445c0 Compare August 17, 2025 14:46
@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Aug 17, 2025
@PureWeen PureWeen moved this from In Progress to Ready To Review in MAUI SDK Ongoing Aug 17, 2025
@jonathanpeppers
Copy link
Member Author

I just merged RC1 changes for sdk and runtime , should we rebase and recreate ?

No, we should take this for now and do a future one. The future one might be RC 2.

@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Aug 18, 2025
@rmarinho rmarinho merged commit c1c98c2 into net10.0 Aug 18, 2025
127 of 129 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Aug 18, 2025
@rmarinho rmarinho deleted the dev/peppers/net10rc1-aotprofile branch August 18, 2025 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants