[net10.0] Merge main to net10 #31210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…:DataType attributes (#30219) * Initial plan * Fix XAML compiled binding warnings by adding x:DataType attributes Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
…on (#30313) * Initial plan * Convert first batch of XML docs to inline documentation Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Convert second batch of XML docs to inline documentation Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Convert third batch of XML docs to inline documentation Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> # Conflicts: # src/Controls/src/Core/BoxView/BoxView.cs * Convert fourth batch (50 files) of XML docs to inline documentation Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Convert fifth batch (100 files) of XML docs to inline documentation - Major milestone! Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Fix documentation issues - remove T: prefixes, fix generic types, replace "To be added", spell check Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Fix internal use documentation and CS1573 warnings Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Delete unused XML documentation files from converted classes Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * Delete 76 truly unreferenced XML documentation files Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Conflicts: # src/Controls/src/Core/CarouselPage/CarouselPage.cs # src/Controls/src/Core/Cells/EntryCell.cs # src/Controls/src/Core/Cells/ImageCell.cs # src/Controls/src/Core/Cells/SwitchCell.cs # src/Controls/src/Core/Cells/TextCell.cs # src/Controls/src/Core/Cells/ViewCell.cs # src/Controls/src/Core/ClickGestureRecognizer.cs # src/Controls/src/Core/ClickedEventArgs.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs # src/Controls/src/Core/DatePicker/DatePicker.cs # src/Controls/src/Core/FileImageSource.cs # src/Controls/src/Core/ListView/ListView.cs # src/Controls/src/Core/Menu/MenuItem.cs # src/Controls/src/Core/NavigationPage/NavigationPage.cs # src/Controls/src/Core/PlatformConfiguration/AndroidSpecific/ListView.cs # src/Controls/src/Core/PlatformConfiguration/WindowsSpecific/ListView.cs # src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Cell.cs # src/Controls/src/Core/PlatformConfiguration/iOSSpecific/ListView.cs
There was a problem hiding this comment.
Pull Request Overview
This PR merges the latest changes from the main branch to the net10 branch, focusing on improving API documentation by replacing XML documentation includes with inline documentation summaries and parameter descriptions. The changes also include updates to XAML pages with x:DataType declarations for compile-time binding support.
- Replace XML file includes with inline documentation summaries and parameters
- Update XAML pages to include x:DataType declarations for type safety
- Modernize documentation format across platform-specific configurations and core controls
Reviewed Changes
Copilot reviewed 252 out of 252 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| TestResultPage.xaml | Added namespace and x:DataType for TestResultViewModel |
| TestAssemblyPage.xaml | Added x:DataType for TestAssemblyViewModel and updated CollectionView bindings |
| HomePage.xaml | Added namespace and x:DataType for HomeViewModel with binding updates |
| SwipeView.cs | Replaced XML include with inline parameter documentation |
| SolidColorBrush.cs | Updated Equals method documentation from XML include to inline param |
| Shell.cs | Replaced XML includes with detailed inline documentation for GoToAsync methods |
| Routing.cs | Updated GetOrCreateContent method with inline parameter documentation |
| Registrar.cs | Replaced XML includes with inline documentation for RegisterAll methods |
| PlatformConfiguration/*.cs | Extensive documentation updates from XML includes to inline summaries |
| Core controls | Updated documentation format for labels, navigation, layouts, and other controls |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| SelectionMode="Single" | ||
| SelectionChangedCommand="{Binding NavigateToResultCommand}" | ||
| SelectionChangedCommandParameter="{Binding SelectedItem, Source={Reference testsList}}"> | ||
| SelectionChangedCommandParameter="{Binding SelectedItem, Source={Reference testsList}, x:DataType=CollectionView}">> |
There was a problem hiding this comment.
There is an extra '>' character at the end of this line that creates invalid XAML syntax.
Copilot uses AI. Check for mistakes.
| SelectionMode="Single" | ||
| SelectionChangedCommand="{Binding NavigateToTestAssemblyCommand}" | ||
| SelectionChangedCommandParameter="{Binding SelectedItem, Source={Reference assemblyList}}"> | ||
| SelectionChangedCommandParameter="{Binding SelectedItem, Source={Reference assemblyList}, x:DataType=CollectionView}">> |
There was a problem hiding this comment.
There is an extra '>' character at the end of this line that creates invalid XAML syntax.
Copilot uses AI. Check for mistakes.
| /// <include file="../../docs/Microsoft.Maui.Controls/PinchGestureUpdatedEventArgs.xml" path="//Member[@MemberName='Status']/Docs/*" /> | ||
| /// <summary>Whether the gesture started, is running, or has finished.</summary> | ||
| /// <remarks>The origin of the pinch, | ||
| /// The initial value of the</remarks> |
There was a problem hiding this comment.
The summary documentation appears incomplete. The following remarks mention 'The origin of the pinch,' and 'The initial value of the' but are cut off and should be completed or removed.
Suggested change
| /// The initial value of the</remarks> |
Copilot uses AI. Check for mistakes.
|
|
||
| /// <include file="../../docs/Microsoft.Maui.Controls/NavigationEventArgs.xml" path="//Member[@MemberName='Page']/Docs/*" /> | ||
| /// <summary>Gets the page that was removed or is newly visible.</summary> | ||
| /// <remarks>For</remarks> |
There was a problem hiding this comment.
The remarks section is incomplete and should either be completed with meaningful content or removed.
Suggested change
| /// <remarks>For</remarks> |
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Bring latest changes from main to net10.0