KEMBAR78
[Windows] Implement FlyoutHeaderBehavior property by jsuarezruiz · Pull Request #5345 · dotnet/maui · GitHub
Skip to content

[Windows] Implement FlyoutHeaderBehavior property #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2022
Merged

[Windows] Implement FlyoutHeaderBehavior property #5345

merged 6 commits into from
Apr 28, 2022

Conversation

@jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 16, 2022 •
edited
Loading

Description of Change

Implement FlyoutHeaderBehavior property on Shell Windows.

NOTE: To test this changes used the ShellFlyoutHeaderBehavior class.

Issues Fixed

Fixes #1626

@jsuarezruiz jsuarezruiz added platform/windows area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Mar 16, 2022
PureWeen
PureWeen requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Can the header image not move into the appbar header?

image

@Redth Redth added this to the 6.0.300-rc.1 milestone Mar 21, 2022
@PureWeen PureWeen modified the milestones: 6.0.300-rc.1, 6.0.300-rc.2 Mar 22, 2022
@Redth Redth modified the milestones: 6.0.300-rc.2, 6.0.300-rc.3 Apr 20, 2022
@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Redth Redth merged commit 93f0663 into main Apr 28, 2022
@Redth Redth deleted the implement-shellflyoutheaderbehavior-windows branch April 28, 2022 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PureWeen PureWeen PureWeen requested changes

Assignees

@jsuarezruiz jsuarezruiz

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! platform/windows

Projects

None yet

Milestone

6.0.300-rc.3

Development

Successfully merging this pull request may close these issues.

[Shell, WinUI] FlyoutHeaderBehavior

5 participants

@jsuarezruiz @PureWeen @Redth @samhouts @rmarinho