Remove iOS Compat ColorExtension ToUIColor overlap #5854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
requested changes
Apr 6, 2022
There was a problem hiding this comment.
(CoreCompile target) ->
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(51,54): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(52,57): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(53,62): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(57,62): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(62,62): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(67,63): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\CustomRenderers\_12372CustomRenderer.cs(73,62): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\SearchbarEffect.cs(24,46): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\SearchbarEffect.cs(34,47): error CS1061: 'Color' does not contain a definition for 'ToPlatform' and no accessible extension method 'ToPlatform' accepting a first argument of type 'Color' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\iOS\Compatibility.ControlGallery.iOS.csproj]
PureWeen
reviewed
Apr 6, 2022
src/Compatibility/Core/src/iOS/Extensions/CompatibilityColorExtensions.cs
Show resolved
Hide resolved
rmarinho
approved these changes
Apr 29, 2022
samhouts
added
the
migration-compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes all the
Microsoft.Maui.Controls.Compatibility.Platform.iOS.ToUIColor()overloads since it was overlapping withMicrosoft.Maui.Platform.ColorExtensions.ToPlatform()and therefore causing confusionAPI Changes
❌ Deprecated (and implementation now uses
ToPlatform)public static UIColor ToUIColor(this Color color)public static UIColor ToUIColor(this Color color, Color defaultColor)public static UIColor ToUIColor(this Color color, UIColor defaultColor)Issues Fixed
Fixes #4601