KEMBAR78
Fix cleanup and wiring up when changing out the content on window by PureWeen · Pull Request #5917 · dotnet/maui · GitHub
Skip to content

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented Apr 8, 2022

Description of Change

Do a better job cleaning up the old views and wiring up the new views when the user swaps out the content on window

Issues Fixed

Fixes #5470

@jsuarezruiz
Copy link
Contributor

/azp run

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Apr 11, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) April 13, 2022 00:36
# Conflicts:
#	src/Core/src/Platform/Windows/NavigationRootManager.cs
#	src/Core/src/Platform/Windows/RootNavigationView.xaml.cs
#	src/Core/src/Platform/Windows/WindowRootView.cs
@PureWeen PureWeen added this to the 6.0.300-rc.2 milestone Apr 18, 2022
@Redth Redth modified the milestones: 6.0.300-rc.2, 6.0.300-rc.3 Apr 20, 2022
@PureWeen PureWeen requested a review from SotoiGhost April 21, 2022 16:35
Copy link
Contributor

@SotoiGhost SotoiGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@PureWeen PureWeen merged commit 32ebee3 into main Apr 27, 2022
@PureWeen PureWeen deleted the fix_main_page_swap branch April 27, 2022 02:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell Toolbar does not always show

5 participants