Fix nullable annotations for Preferences
#6013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
area-essentials
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
previously requested changes
Apr 13, 2022
There was a problem hiding this comment.
Build failing
"D:\a\_work\1\s\Microsoft.Maui.BuildTasks.slnf" (Build target) (1:2) ->
"D:\a\_work\1\s\src\Core\src\Core.csproj" (default target) (2:40) ->
"D:\a\_work\1\s\src\Core\src\Core.csproj" (Build target) (2:43) ->
"D:\a\_work\1\s\src\Essentials\src\Essentials.csproj" (default target) (8:55) ->
(CoreCompile target) ->
D:\a\_work\1\s\src\Essentials\src\Preferences\Preferences.shared.cs(38,12): error CS0246: The type or namespace name 'NotNullIfNotNullAttribute' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj]
D:\a\_work\1\s\src\Essentials\src\Preferences\Preferences.shared.cs(38,12): error CS0246: The type or namespace name 'NotNullIfNotNull' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj]
D:\a\_work\1\s\src\Essentials\src\Preferences\Preferences.shared.cs(101,12): error CS0246: The type or namespace name 'NotNullIfNotNullAttribute' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj]
D:\a\_work\1\s\src\Essentials\src\Preferences\Preferences.shared.cs(101,12): error CS0246: The type or namespace name 'NotNullIfNotNull' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj]
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Apr 15, 2022
mattleibow
requested changes
Apr 15, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Apr 21, 2022
mattleibow
requested changes
Apr 22, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Setting and Getting
nullis totally valid (I'm using this functionality in my app), so existing annotations are incorrect.Updated annotations to reflect underlying logic.
Issues Fixed
Fixes #
Do I need to create an issue for such a small change?