Update template styles #6312
Merged
Update template styles #6312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
approved these changes
Apr 20, 2022
rachelkang
added
area-xaml
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
reviewed
Apr 21, 2022
| <VisualStateGroupList> | ||
| <VisualStateGroup x:Name="CommonStates"> | ||
| <VisualState x:Name="Normal"> | ||
| <VisualState.Setters> |
There was a problem hiding this comment.
Could we include some kind of TODO: comment to avoid forgetting to add this again after fixing AppThemeBinding?
There was a problem hiding this comment.
Leaving this blank is the correct behavior. This way when you travel back to normal in unsets back to the values set on the control itself. If you have setters inside Normal then it causes code like this
<Button TextColor=Green />
To no longer work, because the VSM will just use the VSM setters over the property set on the control itself.
Eilon
added
t/a11y
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Temporarily