Adds FlowDirection Design TypeConverter #6384
Conversation
|
@mgoertz-msft does this look correct? |
|
@Redth Looks good, but it begs the question why we wouldn't just add the new values to the enum and remove the runtime TypeConverter? There also still seems to be a slight difference in what the runtime TC accepts. The new values are case insensitive whereas the enum values and this DT converter I believe do check the case. |
|
Adding duplicate values seemed off to me... @StephaneDelcroix thoughts ? |
|
also, as @mgoertz-msft said, Xaml syntax is case-sensitive, where CSS is not. Depending on what's our goal here, there are multiple courses of action: The right path forward is 4/ (imho), and in the meantime I could create a Compiled version of this converter that will fail at compile time |
| AddMemberAttributes("Microsoft.Maui.Controls.VisualElement", "Visual", | ||
| new TypeConverterAttribute(typeof(VisualDesignTypeConverter))); | ||
|
|
||
| AddMemberAttributes("Microsoft.Maui.Controls.VisualElement", "FlowDirection", |
There was a problem hiding this comment.
side question, why do we have a [TypeConverter] on the Property, and not on the Type ?
There was a problem hiding this comment.
Probably because the real type converter is also on the property.
There was a problem hiding this comment.
Probably because the real type converter is also on the property.
that was my question. Why are we doing this at the Core and Controls level. I understand we have to mimic it here
There was a problem hiding this comment.
Yeah, that I don't know. @Redth?
There was a problem hiding this comment.
Not sure, I was mostly just following what had been done for similar cases previously.
There was a problem hiding this comment.
What this means is that the FlowDirection enum will only behave this way for the VisualElement.FlowDirection property. If that type is used for any other property, by 3rd party control vendors for example, then it will behave just like the regular enum and not allow those CSS values to be used.
6 participants
Fixes #6343
Adds a Design TypeConverter for FlowDirection so that XAML editor/intellisense can report the values and invalid values correctly.