Fix android image loading into views #6394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up code using lambdas in java - Use the MauiCustomViewTarget's view directly I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.
|
I think it is a real failure, but I haven't quite figured out why yet. |
|
Maybe it only passed because things weren’t fully working before. |
|
Not sure, I can't seem to make it fail locally... Could be an API level thing I guess, or perhaps the tests are taking too long in CI?
|
|
Though I suppose that test is now timing out so that's probably not correct. |
|
Ok I'm not sure what's happening inside Glide, but the load does actually take this long to fail. I was setting breakpoints in the java code, and from calling |
mattleibow
approved these changes
Apr 22, 2022
jsuarezruiz
approved these changes
Apr 22, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Apr 22, 2022
This was referenced Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the main fix here is using the builder with caching was not retaining the correct builder instance in those cases, this fixes the logic.
fixes #6231
fixes #6228
fixes #6363
fixes #6067