[resizetizer] non-vector images should not resize by default #6419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the Android side of: dotnet#5938 On Android, the linked sample crashes with: Java.Lang.RuntimeException: 'Canvas: trying to draw too large(485897280bytes) bitmap. It appears like this image is simply too big: 1. The image starts at 3008x5340 2. MAUI's build upscales this to 21360x12032, see `obj\Debug\net6.0-android\resizetizer\r\drawable-xxxhdpi` A workaround is to do: <MauiImage Update="Resources\Images\large.jpg" Resize="false" /> Let's make `%(Resize)` of `false` be the default for non-vector images. If users specify `%(BaseSize)` or `%(Resize)` themselves, then we'll continue to use those settings. I updated some tests around this scenario. This has both app size and performance implications for all platforms -- as usage of `.png` or `.jpg` file will no longer get upscaled to enormous dimensions. Yay!
mattleibow
approved these changes
Apr 22, 2022
Redth
approved these changes
Apr 22, 2022
samhouts
added
area-image
ghost
added
the
legacy-area-controls
Eilon
removed
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android, the linked sample crashes with:
It appears like this image is simply too big:
The image starts at 3008x5340
MAUI's build upscales this to 21360x12032, see
obj\Debug\net6.0-android\resizetizer\r\drawable-xxxhdpiA workaround is to do:
Let's make
%(Resize)offalsebe the default for non-vectorimages. If users specify
%(BaseSize)or%(Resize)themselves, thenwe'll continue to use those settings.
I updated some tests around this scenario.
This has both app size and performance implications for all platforms
-- as usage of
.pngor.jpgfile will no longer get upscaled toenormous dimensions. Yay!
Issues Fixed
Fixes Android side of: #5938
Windows side is a separate issue about image rotation.