KEMBAR78
Update ShellToolBar when applicable appearance elements change by PureWeen · Pull Request #6422 · dotnet/maui · GitHub
Skip to content

Conversation

@PureWeen
Copy link
Member

Description of Change

  • Propagate shell color settings to xplat toolbar VirtualView
  • Fix icon coloring on WinUI !!!

Issues Fixed

Fixes #3077

@PureWeen PureWeen requested a review from SotoiGhost April 27, 2022 14:35
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

         D:\a\_work\1\s\src\Core\src\Platform\Windows\RootNavigationView.xaml.cs(225,8): error CS0103: The name 'HeaderControl' does not exist in the current context [D:\a\_work\1\s\src\Core\src\Core.csproj]
         D:\a\_work\1\s\src\Core\src\Platform\Windows\RootNavigationView.xaml.cs(227,5): error CS0103: The name 'HeaderControl' does not exist in the current context [D:\a\_work\1\s\src\Core\src\Core.csproj]
         D:\a\_work\1\s\src\Core\src\Platform\Windows\RootNavigationView.xaml.cs(228,5): error CS0103: The name 'HeaderControl' does not exist in the current context [D:\a\_work\1\s\src\Core\src\Core.csproj]

@PureWeen PureWeen requested a review from rmarinho April 28, 2022 15:37
Copy link
Contributor

@SotoiGhost SotoiGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍🏼

@PureWeen PureWeen enabled auto-merge (squash) April 28, 2022 16:43
@PureWeen PureWeen disabled auto-merge April 28, 2022 17:32
@PureWeen PureWeen merged commit b50ed56 into main Apr 28, 2022
@PureWeen PureWeen deleted the fix_shell_colors branch April 28, 2022 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Shell.BackgroundColor in UWP and iOS

5 participants