KEMBAR78
Fix theme and NRE on Android and Fix Icons on WinUI by PureWeen · Pull Request #6491 · dotnet/maui · GitHub
Skip to content

Fix theme and NRE on Android and Fix Icons on WinUI #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

Fix theme and NRE on Android and Fix Icons on WinUI #6491

merged 3 commits into from
Apr 26, 2022

Conversation

@PureWeen
Copy link
Member

Description of Change

  • Fix Android so it doesn't throw an NRE when trying to load icons
  • Fix WinUI so it can loads icons into the popup menu
  • parent MenuItems to ViewCell

Issues Fixed

Fixes #6155

@PureWeen PureWeen added this to the 6.0.300-rc.3 milestone Apr 25, 2022
@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-listview ListView and TableView labels Apr 26, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) April 26, 2022 12:51
@PureWeen PureWeen merged commit 69da9f5 into main Apr 26, 2022
@PureWeen PureWeen deleted the listview_nre_contextmenu branch April 26, 2022 14:36
@PureWeen PureWeen mentioned this pull request Apr 30, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees

No one assigned

Labels

area-controls-listview ListView and TableView fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! t/bug Something isn't working

Projects

None yet

Milestone

6.0.300-rc.3

Development

Successfully merging this pull request may close these issues.

Context menu on wrong position in Windows, crashes in Android

4 participants

@PureWeen @jsuarezruiz @mattleibow @samhouts