[Windows] MenuBarItems are now rendered when Shell.Title is not set #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
changed the title
jsuarezruiz
added
platform/windows
area-controls-shell
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
requested changes
Apr 26, 2022
PureWeen
requested changes
Apr 27, 2022
There was a problem hiding this comment.
- So, I think we need to restrict this check to windows only. iOS/Catalyst/Android shouldn't show the toolbar if the MenuBarItems are present. That behavior is only relevant on Windows
- Given that I think it makes sense to move your tests to
ShellTests.csand then if you look at theNavigationPageTeststhere are checks in there forIsNavigationBarVisiblewhich check at the platform level to see if the NavigationBar is visible. We can probably move those methods up toHandlerTestBase
PureWeen
approved these changes
Apr 28, 2022
* This fixes issue #6303
* Added tests for Shell.Toolbar.IsVisible
* Moved IsNavigationBarVisible methods to HandlerTestBase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #6303