-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Xaml] add designTypeConverters for FlexEnums #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
protected override string[] KnownValues | ||
=> new[] { | ||
"Start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So all the flex-* values that the FlexEnumConverters allow aren't needed here because only CSS can use them but not XAML? How do you actually prevent those values from being used in XAML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't prevent it's usage at this time unfortunately, but we frown at it. What I'm realising right now is that we prevent XAML compilation of that value, due to [TypeConverter] attached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the same story as the FlowDirection PR we merged a few days ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, and I didn't understand how XAML was going to not support those values there either, but now I have my answer. With the new design time TypeConverters the "frown at it" will become much more visible to everyone. I guess we'll see if our users will frown at that. :-)
Since this is not sdk style project
Description of Change