KEMBAR78
[Xaml] add designTypeConverters for FlexEnums by StephaneDelcroix · Pull Request #6537 · dotnet/maui · GitHub
Skip to content

Conversation

@StephaneDelcroix
Copy link
Contributor


protected override string[] KnownValues
=> new[] {
"Start",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all the flex-* values that the FlexEnumConverters allow aren't needed here because only CSS can use them but not XAML? How do you actually prevent those values from being used in XAML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't prevent it's usage at this time unfortunately, but we frown at it. What I'm realising right now is that we prevent XAML compilation of that value, due to [TypeConverter] attached.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the same story as the FlowDirection PR we merged a few days ago

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, and I didn't understand how XAML was going to not support those values there either, but now I have my answer. With the new design time TypeConverters the "frown at it" will become much more visible to everyone. I guess we'll see if our users will frown at that. :-)

@Redth Redth enabled auto-merge (squash) April 28, 2022 13:33
@Redth Redth merged commit d395301 into main Apr 28, 2022
@Redth Redth deleted the fix_6325 branch April 28, 2022 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FlexLayout property values don't have intellisense

5 participants