[android] update AOT profile #6548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should those values be set in the initial java setter code? I wonder if we are doing something else wrong... |
jonathanpeppers
commented
Apr 27, 2022
Comment on lines
-4995
to
+5001
| void Microsoft.Maui.Handlers.ButtonHandler:MapStrokeColor (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButtonStroke) | ||
| void Microsoft.Maui.Handlers.ButtonHandler:MapStrokeThickness (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButtonStroke) | ||
| void Microsoft.Maui.Handlers.ButtonHandler:MapStrokeColor (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButton) | ||
| void Microsoft.Maui.Handlers.ButtonHandler:MapStrokeThickness (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButton) |
There was a problem hiding this comment.
@mattleibow I think it's because the signature changed on these -- and so now the AOT profile just needs updated.
|
There are some changes in the template, let me run this again |
For dotnet/maui/main, I noticed the startup path changed a bit. Some
methods are not in the profile, such as:
AOT: NOT FOUND: Microsoft.Maui.Platform.ButtonExtensions:UpdateBackground (Google.Android.Material.Button.MaterialButton,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Platform.ButtonExtensions:UpdateBackground (Google.Android.Material.Button.MaterialButton,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Handlers.ButtonHandler:MapStrokeThickness (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Platform.ButtonExtensions:UpdateStrokeThickness (Google.Android.Material.Button.MaterialButton,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Handlers.ButtonHandler:MapStrokeColor (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Platform.ButtonExtensions:UpdateStrokeColor (Google.Android.Material.Button.MaterialButton,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Handlers.ButtonHandler:MapCornerRadius (Microsoft.Maui.Handlers.IButtonHandler,Microsoft.Maui.IButton).
AOT: NOT FOUND: Microsoft.Maui.Platform.ButtonExtensions:UpdateCornerRadius (Google.Android.Material.Button.MaterialButton,Microsoft.Maui.IButton).
There were also a couple changes in the template:
* 27c8d7e
* 6484698
I had to adjust some of the code in `src/ProfiledAot` to account for
changes in the template.
I also included the use of `Label` to set `FontAttributes` and `Text`,
so these properties are also in the profile.
`dotnet new maui` on a Pixel 5:
Before:
Average(ms): 567.8
Std Err(ms): 2.63227826965328
Std Dev(ms): 8.32399476747126
After:
Average(ms): 558.8
Std Err(ms): 2.57250418420997
Std Dev(ms): 8.13497251241686
jonathanpeppers
force-pushed
the
ProfiledAOTRC3
branch
from
e023442 to
c1a2514
Compare
Redth
approved these changes
Apr 28, 2022
Eilon
added
the
perf/general
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dotnet/maui/main, I noticed the startup path changed a bit. Some
methods are not in the profile, such as:
There were also a couple changes in the template:
I had to adjust some of the code in
src/ProfiledAotto account forchanges in the template.
I also included the use of
Labelto setFontAttributesandText,so these properties are also in the profile.
dotnet new mauion a Pixel 5: