KEMBAR78
Fix various combinations of Shell Elements on WinUI by PureWeen · Pull Request #6564 · dotnet/maui · GitHub
Skip to content

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented Apr 27, 2022

Description of Change

  • Fixed Shell to better calculate the items for the top tabs
  • Fixed Flyout Item to pick the correct non-implicit shell item so it correctly displays as selected

Issues Fixed

Fixes #6558
Fixes #6033
Fixes #6243
Fixes #6061

@PureWeen
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

# Conflicts:
#	src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Windows.cs
@jsuarezruiz jsuarezruiz added platform/windows area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Apr 28, 2022
@PureWeen PureWeen enabled auto-merge (squash) April 28, 2022 14:06
@PureWeen PureWeen merged commit 026e3b6 into main Apr 28, 2022
@PureWeen PureWeen deleted the fix_shell_selection_scenarios branch April 28, 2022 14:58
@PureWeen PureWeen mentioned this pull request Apr 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! platform/windows

Projects

None yet

4 participants