KEMBAR78
Update AdaptiveTrigger to support multi-window by mattleibow · Pull Request #6627 · dotnet/maui · GitHub
Skip to content

Conversation

@mattleibow
Copy link
Member

Description of Change

The AdaptiveTrigger implementation assumed a single window that was loaded via the Application.MainPage property - which is not the case with multiple windows.

This PR updates the code to rather look for the element's window, and use that size.

Issues Fixed

Fixes #5946
Supersedes #6337

@mattleibow mattleibow requested review from PureWeen and hartez April 28, 2022 18:11
@mattleibow mattleibow self-assigned this Apr 28, 2022
@mattleibow mattleibow added the t/bug Something isn't working label Apr 28, 2022
@mattleibow mattleibow added this to the 6.0.300-rc.3 milestone Apr 28, 2022
@mattleibow mattleibow added the area-xaml XAML, CSS, Triggers, Behaviors label Apr 28, 2022
@Redth Redth merged commit 0c842e6 into main Apr 29, 2022
@Redth Redth deleted the dev/fix-adaptive-trigger branch April 29, 2022 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-xaml XAML, CSS, Triggers, Behaviors fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VisualStateGroup System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.

3 participants