[Tizen] Renaming APIs Native to Platform #6643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Apr 29, 2022
| public IPlatformViewHandler? Parent { get; private set; } | ||
|
|
||
| public EvasObject NativeParent => MauiContext?.GetNativeParent() ?? throw new InvalidOperationException($"NativeParent cannot be null here"); | ||
| public EvasObject PlatformParent => MauiContext?.GetPlatformParent() ?? throw new InvalidOperationException($"PlatformParent cannot be null here"); |
There was a problem hiding this comment.
This appears to be the only breaking change but it should be ok because I am not sure we have that many Maui Tizen libs just yet since we just released RC with this.
There was a problem hiding this comment.
There are a couple of other similar properties, but they are protected and on Shell things. Even less likely to be hit.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
approved these changes
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
According to naming rule of .NET MAUI project, I've replaced all instances of 'Native' to 'Platform' in Tizen backend.
For more background on this change, see #4451.