Ensure glide targets run once #6739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also refactored the managed ImageLoaderCallback types to use a common base to avoid duplication issues - Fixed some formatting - Updated readme/docs on the correct way to build the aar - New aar build
mattleibow
commented
May 2, 2022
Comment on lines
+28
to
+30
| if (completed) | ||
| return; | ||
| this.completed = true; |
There was a problem hiding this comment.
This is the real fix - for both the onLoadFailed and onResourceReady methods. For both MauiCustomTarget and MauiCustomViewTarget.
In no world is calling this on the same instance valid because the ctor takes a callback which is wrapping a TaskCompletionSource. Even if we use the TryXxx methods, this means nothing because there is work that is done after the await - and if nothing is awaiting, then nothing will get done.
Comment on lines
-9
to
+7
| internal class ImageLoaderResultCallback : Java.Lang.Object, IImageLoaderCallback | ||
| class ImageLoaderResultCallback : ImageLoaderCallbackBase<IImageSourceServiceResult<Drawable>> |
There was a problem hiding this comment.
Sorry, can't handle duplicate code with just a differing return type.
Eilon
added
the
area-setup
mattleibow
added
platform/android
area-image
PureWeen
approved these changes
May 3, 2022
Eilon
added
area-controls-image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed