-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement FlowDirection property in ViewHandlers #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmrAlSayed0
reviewed
May 25, 2021
rachelkang
requested changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e4d02a7 to
e56bd94
Compare
29241b3 to
c18f0ed
Compare
6f052e8 to
bfebb7a
Compare
bfebb7a to
f87e6bf
Compare
rmarinho
requested changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of issus, some controls don't support RTL.
- Starting app with Hebrew (RTL language) doesn't show the app in RTL on iOS
- Forcing RTL on my android Device and starting the app doesnt show the sample app with RTL on
src/Controls/src/Core/HandlerImpl/VisualElement/VisualElement.Impl.cs
Outdated
Show resolved
Hide resolved
mattleibow
reviewed
Aug 25, 2021
rmarinho
approved these changes
Aug 25, 2021
rachelkang
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-dialog
area-controls-editor
Editor
area-controls-entry
Entry
area-controls-flyout
Flyout
area-controls-flyoutpage
FlyoutPage
area-controls-label
Label, Span
area-controls-map
Map / Maps
area-controls-picker
Picker
area-layout
StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
area-localization
Localization and globalization issues
area-navigation
NavigationPage
fixed-in-6.0.100-rc.1.7
Look for this fix in 6.0.100-rc.1.7!
platform/android
platform/ios
platform/windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description of Change
FlowDirectionproperty in ViewHandlers.Platforms Affected
PR Checklist