KEMBAR78
Mark package content items as "user read-only" by davkean · Pull Request #6480 · dotnet/project-system · GitHub
Skip to content

Mark package content items as "user read-only" #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Mark package content items as "user read-only" #6480

merged 1 commit into from
Aug 11, 2020

Conversation

@davkean
Copy link
Member

@davkean davkean commented Aug 10, 2020 •
edited by ghost
Loading

Fixes: #2141

This marks package content items as user read-only, which causes them to be opened read-only in the editor.

This depends on https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/266425.

Microsoft Reviewers: Open in CodeFlow

@davkean
Mark package content items as "user read-only"
ca3df43 
Fixes: dotnet#2141

This marks package content items as user read-only, which causes them to be opened read-only in the editor.

This depends on https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/266425.
@davkean davkean requested a review from a team as a code owner August 10, 2020 02:53
@ghost ghost added the Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. label Aug 10, 2020
@davkean davkean mentioned this pull request Aug 10, 2020
Closed
@davkean davkean merged commit bc20cc5 into dotnet:master Aug 11, 2020
@davkean davkean deleted the ReadOnlyPackages branch August 11, 2020 02:47
@ghost ghost added this to the 16.8 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

+1 more reviewer

@dmonroym dmonroym dmonroym approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support.

Projects

None yet

Milestone

16.8

Development

Successfully merging this pull request may close these issues.

Disallow editing contentfiles from packages

3 participants

@davkean @drewnoakes @dmonroym