-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Merge 'dotnet/main' into InlineArrays #68140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlekseyTs
merged 73 commits into
dotnet:features/InlineArrays
from
AlekseyTs:InlineArrays_09
May 9, 2023
Merged
Merge 'dotnet/main' into InlineArrays #68140
AlekseyTs
merged 73 commits into
dotnet:features/InlineArrays
from
AlekseyTs:InlineArrays_09
May 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for member recommendations
* Make OrderBy binary compat across TFMs This puts `OrderBy` back into our Workspaces layer. It also addresses a number of other places where our `internal` API was not consistent with `public` API when polyfills were involved. Please consult the markdown doc for the rational here. That is going to be a repo artifact so lets focus the _why_ discussion there. Want it to be clear for future readers why this change is being made. * Apply suggestions from code review Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com> * pr feedback * Apply suggestions from code review Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Fred Silberberg <fred@silberberg.xyz> * flip condition order --------- Co-authored-by: Jared Parsons <jared@popcornbear.org> Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com> Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
* Fix referencing an alias in an expression * Update IDE side * Add success case * Move tests * Update src/Compilers/CSharp/Test/Syntax/Parsing/UsingDirectiveParsingTests.cs * LINT
* More source build work This removes the differences between typical CI and developer builds with respect to TFM set. That will avoid anymore situations where CI is building and developer builds are not (or vice versa). There is still the chance that developer builds and CI will succeed but the source build CI will fail. That is in unavoidable consequence of how source build works though given it explicitly builds a different TFM set than traditional build. * fixup --------- Co-authored-by: Jared Parsons <jared@popcornbear.org>
We were not handling unconverted expressions in some bad code scenarios, leading to issues where bad unconverted objects slipped through and broke further downstream scenarios. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1806208.
Update semantic token names to conform be spec compatible
* Feedback on cachine constructed Nullable<T> types * Simplify * Use a concurrent cache to cap number of enums stored * use old form * Add assert info
* Add a test * Fix conditional operator nullable walker assertion * Clarify comment
…ariable to prepare it for error recovery binding. (dotnet#68034) Fixes dotnet#68026.
This CI definition should have the same default queue as roslyn-integration-CI.
Co-authored-by: Andrew Hall <andrha@microsoft.com>
…tnet#66430)" This reverts commit ec485d1.
Update roslyn-integration-corehost default queue
…-deps-to-release/dev17.7 Merge release/dev17.6-vs-deps to release/dev17.7
…-main Merge release/dev17.7 to main
Move potential expensive task of ItemManager to ThreadPool
Use client languageId when file path is ambiguous
Add dependency to x64 SerivceHub vsix
Switch to a background thread before performing work in AbstractAddImportsPasteCommandHandler
Co-authored-by: Jan Jones <janjones@microsoft.com>
* Add a test * Preserve removed entries in `SyntaxNodeProvider`
Add ServiceHub vsix for ARM64
jjonescz
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.