KEMBAR78
Merge 'dotnet/main' into InlineArrays by AlekseyTs · Pull Request #68140 · dotnet/roslyn · GitHub
Skip to content

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

genlu and others added 30 commits November 16, 2022 12:52
* Make OrderBy binary compat across TFMs

This puts `OrderBy` back into our Workspaces layer. It also addresses a
number of other places where our `internal` API was not consistent with
`public` API when polyfills were involved.

Please consult the markdown doc for the rational here. That is going to
be a repo artifact so lets focus the _why_ discussion there. Want it to
be clear for future readers why this change is being made.

* Apply suggestions from code review

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>

* pr feedback

* Apply suggestions from code review

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>

* flip condition order

---------

Co-authored-by: Jared Parsons <jared@popcornbear.org>
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
* Fix referencing an alias in an expression

* Update IDE side

* Add success case

* Move tests

* Update src/Compilers/CSharp/Test/Syntax/Parsing/UsingDirectiveParsingTests.cs

* LINT
* More source build work

This removes the differences between typical CI and developer builds with
respect to TFM set. That will avoid anymore situations where CI is
building and developer builds are not (or vice versa).

There is still the chance that developer builds and CI will succeed but
the source build CI will fail. That is in unavoidable consequence of how
source build works though given it explicitly builds a different TFM set
than traditional build.

* fixup

---------

Co-authored-by: Jared Parsons <jared@popcornbear.org>
We were not handling unconverted expressions in some bad code scenarios, leading to issues where bad unconverted objects slipped through and broke further downstream scenarios. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1806208.
Update semantic token names to conform be spec compatible
* Feedback on cachine constructed Nullable<T> types

* Simplify

* Use a concurrent cache to cap number of enums stored

* use old form

* Add assert info
* Add a test

* Fix conditional operator nullable walker assertion

* Clarify comment
…ariable to prepare it for error recovery binding. (dotnet#68034)

Fixes dotnet#68026.
This CI definition should have the same default queue as
roslyn-integration-CI.
Co-authored-by: Andrew Hall <andrha@microsoft.com>
Update roslyn-integration-corehost default queue
…-deps-to-release/dev17.7

Merge release/dev17.6-vs-deps to release/dev17.7
Move potential expensive task of ItemManager to ThreadPool
@AlekseyTs AlekseyTs requested review from cston and jjonescz May 9, 2023 17:49
@AlekseyTs AlekseyTs requested review from a team, 333fred and dibarbet as code owners May 9, 2023 17:49
@AlekseyTs AlekseyTs requested a review from a team May 9, 2023 17:49
@AlekseyTs AlekseyTs requested a review from a team as a code owner May 9, 2023 17:49
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label May 9, 2023
@AlekseyTs
Copy link
Contributor Author

@cston, @jjonescz, @dotnet/roslyn-compiler Need a sign off on a fast-forward merge between branches

@AlekseyTs AlekseyTs enabled auto-merge May 9, 2023 17:51
@AlekseyTs AlekseyTs merged commit fe6acba into dotnet:features/InlineArrays May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.