KEMBAR78
Omit Slice call when start is 0 and 0 <= end <=length. by AlekseyTs · Pull Request #68660 · dotnet/roslyn · GitHub
Skip to content

Omit Slice call when start is 0 and 0 <= end <=length. #68660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2023
Merged

Omit Slice call when start is 0 and 0 <= end <=length. #68660

merged 2 commits into from
Jun 19, 2023

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from cston and jjonescz June 16, 2023 16:29
@AlekseyTs AlekseyTs requested a review from a team as a code owner June 16, 2023 16:29
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 16, 2023
cston
cston reviewed Jun 18, 2023
View reviewed changes
src/Compilers/CSharp/Test/Emit2/Semantics/InlineArrayTests.cs
IL_001b: ret
}
");
}
Copy link
Contributor

@cston cston Jun 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

Consider testing [0..], [1..], [y..], [^10..], [^9..], [..^0], [..^1]

@AlekseyTs AlekseyTs enabled auto-merge (squash) June 19, 2023 13:13
@AlekseyTs AlekseyTs merged commit f33c4df into dotnet:features/InlineArrays Jun 19, 2023
@allisonchou allisonchou mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Feature - Inline Arrays untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlekseyTs @jjonescz @cston