-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Merge 'main' into InlineArrays #68717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlekseyTs
merged 642 commits into
dotnet:features/InlineArrays
from
AlekseyTs:InlineArrays_32
Jun 21, 2023
Merged
Merge 'main' into InlineArrays #68717
AlekseyTs
merged 642 commits into
dotnet:features/InlineArrays
from
AlekseyTs:InlineArrays_32
Jun 21, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…green (part 2) Previously, generate assets would generate a tasks.json file that only builds the executable project you picked to debug. Now, it uses the solution if there is a solution available. Completes the fix for: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1800252/
The command line parsing library expects a switch in front of each extension; you can't do --extensions A.dll B.dll. The name of the switch implies otherwise, so let's name this better.
When using source control git compare on VS Code, the LSP request context may contain the wrong document. The original/left side (git://filePath) is specified in the request parameters, but the request context has the new/right side (file://filePath) document. This causes an ArgumentOutOfRange exception because the range requested for the git document might not match the number of lines in the file document. The root cause of this is the use of LocalPaths in the LSP workspace manager. The local paths, which strip out the schema information, don't differentiate between the git and file documents. This means the request context returns the file document when the git document is requested. This fix updates GetDocumentIds to only use local file path for documents of type file. Tested... - Problem source control scenario - New untitled file - Razor file Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798996/
- fix for [Bug 1822454: IntelliCode issue on JSON RPC attach - Unable to create the StarredCompletionProvider](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1822454) - we see an error when initialization is done twice because our brokered service can't be attached to twice - returning completionProvider inside lock in case method has already exited successfully
In the gif below, I typed `"` in both cases, the difference is the first time filter text is empty, the second time "s" was typed. You can see the selected item was not committed in the first case. This behavior is consistent with VS The downside of this approach is there's no telling in UI whether the item would only be committed via TAB 
Noticed this while working on other bugs. Fix commit character promotion, when promoting the most used commit char array on to the list, if it is not the default one, we need to adjust default items properly.
NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
… dependencies directory Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server. Shared dependencies are loaded only withing the load context of the DevKit extension. Follow ups: - https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154 - https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
… Build ID 2192664
… Build ID 2192664
… Build ID 2192664
… Build ID 2192664
… Build ID 2192664
… Build ID 2192664
… Build ID 2192664
…-main Merge release/dev17.7 to main
[main] Update dependencies from dotnet/arcade - Coherency Updates: - Microsoft.SourceLink.GitHub: from 8.0.0-beta.23309.3 to 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk)
Service cleanup
…ctorFieldReference Update references to constant fields in parameter initializers when moving to primary constructors.
…8673) * Extract common logic into helper class * Actually add `lock` snippet * Extract more common logic into helper class * Rename * Remove unused parameters * Add alternative constructor to `SnippetPlaceholder`
…nals build 20230619.1 (dotnet#68695) Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23315.1 -> To Version 8.0.0-alpha.1.23319.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Update all callers of `LocalScopeBinder.BuildLocals` to pass in an `ArrayBuilder` with a capacity of `DefaultLocalSymbolArrayCapacity`.
…620.3 (dotnet#68715) [main] Update dependencies from dotnet/arcade
cston
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.