KEMBAR78
Merge 'main' into InlineArrays by AlekseyTs · Pull Request #68717 · dotnet/roslyn · GitHub
Skip to content

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

akhera99 and others added 30 commits May 22, 2023 15:50
…green (part 2)

Previously, generate assets would generate a tasks.json file that only builds the executable project you picked to debug. Now, it uses the solution if there is a solution available.

Completes the fix for: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1800252/
The command line parsing library expects a switch in front of each extension; you can't do --extensions A.dll B.dll. The name of the switch implies otherwise, so let's name this better.
When using source control git compare on VS Code, the LSP request context may contain the wrong document. The original/left side (git://filePath) is specified in the request parameters, but the request context  has the new/right side (file://filePath) document. This causes an ArgumentOutOfRange exception because the range requested for the git document might not match the number of lines in the file document.

The root cause of this is the use of LocalPaths in the LSP workspace manager. The local paths, which strip out the schema information, don't differentiate between the git and file documents. This means the request context returns the file document when the git document is requested.

This fix updates GetDocumentIds to only use local file path for documents of type file.

Tested...
- Problem source control scenario
- New untitled file
- Razor file

Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798996/
- fix for [Bug 1822454: IntelliCode issue on JSON RPC attach - Unable to create the StarredCompletionProvider](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1822454)
  - we see an error when initialization is done twice because our brokered service can't be attached to twice
  - returning completionProvider inside lock in case method has already exited successfully
In the gif below, I typed `"` in both cases, the difference is the first time filter text is empty, the second time "s" was typed. You can see the selected item was not committed in the first case. This behavior is consistent with VS

The downside of this approach is there's no telling in UI whether the item would only be committed via TAB

![completion-selection.gif](https://dnceng.visualstudio.com/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/git/repositories/7b863b8d-8cc3-431d-b06b-7136cc32bbe6/pullRequests/31357/attachments/completion-selection.gif)
Noticed this while working on other bugs.
Fix commit character promotion, when promoting the most used commit char array on to the list, if it is not the default one, we need to adjust default items properly.
NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
… dependencies directory

Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server.

Shared dependencies are loaded only withing the load context of the DevKit extension.

Follow ups:
- https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154
- https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
dotnet-bot and others added 15 commits June 20, 2023 06:22
[main] Update dependencies from dotnet/arcade
- Coherency Updates:
  - Microsoft.SourceLink.GitHub: from 8.0.0-beta.23309.3 to 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk)
…ctorFieldReference

Update references to constant fields in parameter initializers when moving to primary constructors.
…8673)

* Extract common logic into helper class

* Actually add `lock` snippet

* Extract more common logic into helper class

* Rename

* Remove unused parameters

* Add alternative constructor to `SnippetPlaceholder`
…nals build 20230619.1 (dotnet#68695)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23315.1 -> To Version 8.0.0-alpha.1.23319.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Update all callers of `LocalScopeBinder.BuildLocals` to pass in an `ArrayBuilder` with a capacity of `DefaultLocalSymbolArrayCapacity`.
…620.3 (dotnet#68715)

[main] Update dependencies from dotnet/arcade
@AlekseyTs AlekseyTs requested review from cston and jjonescz June 21, 2023 14:33
@AlekseyTs AlekseyTs requested review from a team as code owners June 21, 2023 14:33
@AlekseyTs AlekseyTs requested a review from a team June 21, 2023 14:33
@AlekseyTs AlekseyTs requested a review from a team as a code owner June 21, 2023 14:33
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 21, 2023
@AlekseyTs
Copy link
Contributor Author

@cston, @jjonescz, @dotnet/roslyn-compiler Need a sign-off on an integration PR. No interesting conflicts.

@AlekseyTs AlekseyTs enabled auto-merge June 21, 2023 14:35
@AlekseyTs AlekseyTs merged commit d8bd406 into dotnet:features/InlineArrays Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.