Merge features/CollectionLiterals into main #68831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Syntax Initial syntax types for collection literals
Merge 'main' into 'features\CollectionLiterals'
Merge 'main' into 'features/CollectionLiterals'
* Do not parse out an attribute that will actually be a collection literal * No need to check for attributes here. They have already been parsed out * Initial parsing * Add handling for certain cases * Rename method * Start a parser test file with a few initial tests * Support parsing -> and ?. * Adding parser tests * Adding parser tests * Improve error recovery * Improve error recovery * Fix parsing * Update test * Update test * Update test * Update test * Update test * BadExpr * Update test * Update test * Lint * Update comment * Add tests * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs * Don't allocate in failure path * Revise comment * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs * Not in expression context * Attributed blocks are not an expr context * Rename * Rename * Rename * not an expression context * Add test marker * Add prototype comment * Add version test * Improve error tolerance * Add tests * Add tests * Add tests * Add tests * Rename * Change indentation * Add tests * Add tests * remove line * Add test * Add tests * Add tests * Cast parsing * Lint * Add parsing tests * Add incremental parsing tests * use file scoped namespaces * Simplify * Add syntax test * Copy diagnostics when converting token --------- Co-authored-by: jnm2 <me@jnm2.com>
Merge main to features/CollectionLiterals
Merge main to features/CollectionLiterals
Merge main to features/CollectionLiterals
Fix collection literal format spacing
Merge main to features/CollectionLiterals
…collection literals (dotnet#68456) * Refine parsing of potentially ambiguous casts/index expressions with collection literals * Update tests * Update tests * Add tests * remove branch * tweak wording * Add test
* Improve parsing in more situations * Add tests * Add test * Add clarity * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs * Tweak
* Fix issue parsing collection literal containing lambdas * Add tests
dotnet#68737) * Fix issue parsing collection literal containing lambdas * Fix parsing collection literals at the start of statement expressions * More cases * Simplify * Avoid any costs in the common cases * Handle indexing case * Improvements * Update tests * Add tests * manual merge * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com> * Add tests * Simplify * docs * Add tests * Add tests * Simplify * REname * Add tests * Simplify * Simplify * Inline * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com> * Remove allocations * Add tests * Add tests --------- Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com>
…erals (dotnet#68787) * Fix parsing certain postfix expressions with top level collection literals * Update test
…pressions (dotnet#68756) * Fix ambiguity parsing collection expressions vs conditional access expressions * Simplify * Fix test * Add tests * Switch to a simpler contextual model * Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs * invert * Simplify * Reset when we go into a new scope * Add test cases * Add test cases * Add incremental test * Add docs
…v17.7 Snap 17.7p3
… Build ID 2211254
… Build ID 2211254
… Build ID 2211254
…29-87bb-f3be4f61f22b Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2211254
Merge main to features/CollectionLiterals
…nto collections-merge-feature
ghost
added
Area-Compilers
untriaged
cston
changed the title
jaredpar
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan #66418