Bump msbuild logger in response to CI image upgrades #71125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
dibarbet
force-pushed
the
bump_msbuild_logger
branch
from
cfb39c5 to
0282ea8
Compare
CyrusNajmabadi
approved these changes
Dec 6, 2023
jasonmalinowski
approved these changes
Dec 6, 2023
jaredpar
approved these changes
Dec 6, 2023
dibarbet
commented
Dec 6, 2023
| which no longer support netcoreapp3.1. Therefore we only change the version referenced here to get the binlog | ||
| checker to work for logs produced by newer MSBuild in CI without requiring product change. | ||
| --> | ||
| <MSBuildStructuredLoggerVersion>2.1.787</MSBuildStructuredLoggerVersion> |
There was a problem hiding this comment.
CI failed because we apparently set the version differently here. However this doesn't seem to make sense anymore - the repo was already on a higher version than this even before I bumped it again. So removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.