KEMBAR78
Do not offer to remove fields when converting to a primary constructor if nullability annotations do not match by CyrusNajmabadi · Pull Request #71126 · dotnet/roslyn · GitHub
Skip to content

Do not offer to remove fields when converting to a primary constructor if nullability annotations do not match #71126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2023
Merged

Do not offer to remove fields when converting to a primary constructor if nullability annotations do not match #71126

merged 3 commits into from
Dec 6, 2023

Conversation

@CyrusNajmabadi
Copy link
Member

Fixes #71117

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 6, 2023 19:22
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 6, 2023
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Dec 6, 2023
Merged
@CyrusNajmabadi CyrusNajmabadi merged commit 0a7e377 into dotnet:main Dec 6, 2023
@ghost ghost added this to the Next milestone Dec 6, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the usePrimaryConstructorNullable branch December 7, 2023 18:01
@allisonchou allisonchou mentioned this pull request Dec 8, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.9 P3 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.9 P3

Development

Successfully merging this pull request may close these issues.

IDE0290 refactoring results in nullability error CS8601

3 participants

@CyrusNajmabadi @akhera99 @Cosifne