KEMBAR78
Semantic snippets: fix inline statement snippets in a "qualified name" edge case by DoctorKrolic · Pull Request #71246 · dotnet/roslyn · GitHub
Skip to content

Semantic snippets: fix inline statement snippets in a "qualified name" edge case #71246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2024
Merged

Semantic snippets: fix inline statement snippets in a "qualified name" edge case #71246

merged 4 commits into from
Jan 8, 2024

Conversation

@DoctorKrolic
Copy link
Contributor

Fixes: #69598

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner December 13, 2023 09:11
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 13, 2023
@DoctorKrolic DoctorKrolic changed the title Inline statement snippets qualified name edge case Semantic snippets: fix inline statement snippets in a "qualified name" edge case Dec 13, 2023
@DoctorKrolic DoctorKrolic requested a review from genlu January 4, 2024 19:57
@DoctorKrolic DoctorKrolic requested a review from genlu January 6, 2024 09:08
genlu
genlu approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@genlu
Copy link
Member

genlu commented Jan 8, 2024

Thanks @DoctorKrolic !

@genlu genlu merged commit 9cb7554 into dotnet:main Jan 8, 2024
@ghost ghost added this to the Next milestone Jan 8, 2024
@DoctorKrolic DoctorKrolic deleted the inline-statement-snippets-qualified-name-edge-case branch January 8, 2024 20:23
@Cosifne Cosifne modified the milestones: Next, 17.10 P1 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genlu genlu genlu approved these changes

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.10 P1

Development

Successfully merging this pull request may close these issues.

Semantic snippets: postfix inline statement snippets are not shown if the next statement starts with a contextual keyword treated as identifier

3 participants

@DoctorKrolic @genlu @Cosifne