Merge 'dotnet/main' into ParamsCollections #71824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up integration test build by only building required dependencies
to match GA version
Don't hard select promoted default item if there's filter text
…type from GetEnumerator instance method (dotnet#71574)
- Replaced (almost) all uses of LSP types in XAML EA APIs
…into nullHarder
Today, when ENCing, we avoid actually emitting IL for members that were not touched by the user. However, we still calculate diagnostics for the entire compilation, which is a lot of unnecessary work. To address this, we plumb the existing symbol filter through `Symbol.ForceComplete`, avoid work on symbols that should not be completed for this ENC session.
* Add tests * Fix field load in assignment * Add more tests
…ForDocData Check Frame's VSFPROPID_IsDocDataInitialized before Getting DocData
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Fix System.Data.SqlClient version alert
Load Roslyn DevKit assemblies into the default ALC
* Do not throw exceptions when we can't make a doc id * Use chars * Simplify code * Add tests * consistency * Push check through * Logic * efficiency * nrt * nrt * update * Add resiliency to null * Docs * Remove unnecessary boolean * REvert * Docs * Docs * Rename * consistency * Add docs * Add docs * Fix * Lint * Remove pooling * Tweak docs * Add assert * Docs * Fix assert * move api * move to non-primary constructor * move to non-primary constructor * move to cleanup pr * move to cleanup pr * move to cleanup pr * move to cleanup pr * move to cleanup pr * move to cleanup pr * Remove boolean flow * Allow null * doc * Fix docs * move back * Add docs * Simplify * Revert * Revert * Revert * Add assertion and comment
…net#71799) Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
… for target type implementing IEnumerable (dotnet#71592)
ghost
added
the
untriaged
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Need a sign-off for a merge from 'main' |
RikkiGibson
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
30 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial merge conflicts only.
The last commit disables/adjusts several ParamsCollections unit-tests because collection expressions conversions rules were changed in 'main'.