KEMBAR78
Fix logic in compilation tracker causing an assert by CyrusNajmabadi · Pull Request #72492 · dotnet/roslyn · GitHub
Skip to content

Fix logic in compilation tracker causing an assert #72492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix logic in compilation tracker causing an assert #72492

merged 1 commit into from
Mar 12, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 11, 2024 22:28
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 11, 2024
ToddGrun
ToddGrun approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit c3565da into dotnet:main Mar 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 12, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the compilationTrackerLocker branch March 12, 2024 12:51
This was referenced Mar 12, 2024
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Mar 21, 2024
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski For review when you get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.10 P3

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @ToddGrun @RikkiGibson