Ensure rented array is always returned (#104223)

stevejgordon · web-flow · commit 60d67b8630bf · 2024-07-01T08:51:58.000-07:00
diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Measurement.cs b/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Measurement.cs
@@ -115,7 +115,10 @@ public Measurement(T value, params ReadOnlySpan<KeyValuePair<string, object?>> t
             }
 
             if (count == 0)
+            {
+                ArrayPool<KeyValuePair<string, object?>>.Shared.Return(array);
                 return Instrument.EmptyTags;
+            }
 
             result = new KeyValuePair<string, object?>[count];
             array.AsSpan().Slice(0, count).CopyTo(result.AsSpan());
