Fix #97736 in MemoryCache.cs with a lock around the TriggerOvercapacityC... method #103992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-caching |
|
@dotnet-policy-service agree |
ADNewsom09
changed the title
|
@ADNewsom09 would it be appropriate to make @myk0la999 the "author" on your first commit? It seems that you took the code he proposed at #97736 to start this. |
|
Sounds fine to me. We implemented this code internally to solve this problem and wanted to share it back.
|
jozkee
reviewed
Jun 26, 2024
src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs
Outdated
Show resolved
Hide resolved
huoyaoyuan
reviewed
Jun 27, 2024
requested by Jozkee Co-authored-by: David Cantú <dacantu@microsoft.com>
jozkee
approved these changes
Jun 27, 2024
|
@ADNewsom09 FYI, I've force-pushed to your branch to list @myk0la999 as the author of 4fed137.
|
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #97736
This PR addresses the excessive CPU and memory usage during the MemoryCache compaction process by limiting the number of concurrent compaction tasks to one. The change ensures that only one thread performs the compaction at any given time, reducing resource spikes and improving overall performance.