KEMBAR78
Resolve some issues impacting the jitstress-isas-x86 runs by tannergooding · Pull Request #104935 · dotnet/runtime · GitHub
Skip to content

Resolve some issues impacting the jitstress-isas-x86 runs #104935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2024
Merged

Resolve some issues impacting the jitstress-isas-x86 runs #104935

merged 3 commits into from
Jul 18, 2024

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 16, 2024 •
edited
Loading

This resolves the SIMD related issues. There's still a couple of JitStress failures but they aren't related to or unique to the jitstress-isas jobs.

Basically there were two issues aroung AND_NOT handling

  1. When EnableSSE2=0 was set, we'd hit an assert during import of AND_NOT
  2. AND_NOT was hitting the handling for AND, and was being treated as commutative where it shouldn't have been

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 16, 2024
@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 16, 2024
Open
Closed
@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tannergooding tannergooding marked this pull request as ready for review July 16, 2024 19:48
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, small fix getting the SIMD related failures for the jitstress-isas jobs all resolved

@tannergooding tannergooding mentioned this pull request Jul 18, 2024
Merged
kunalspathak
kunalspathak approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tannergooding tannergooding merged commit f1d8613 into dotnet:main Jul 18, 2024
@tannergooding tannergooding deleted the fix-isa-stress branch July 18, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tannergooding tannergooding

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding @kunalspathak