Remove HMFs from JIT helpers #111075
Merged
Remove HMFs from JIT helpers #111075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exceptions to QCalls. JIT_ThrowMethodAccessException JIT_ThrowFieldAccessException JIT_ThrowClassAccessException
There was a problem hiding this comment.
Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (7)
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/vm/comutilnative.cpp: Language not supported
- src/coreclr/vm/comutilnative.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
- src/coreclr/vm/qcallentrypoints.cpp: Language not supported
Comments suppressed due to low confidence (3)
src/coreclr/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ThrowHelpers.cs:42
- [nitpick] The method name 'ThrowMethodAccessExceptionInternal' is ambiguous. It should be renamed to 'ThrowMethodAccessExceptionQCall' to better reflect its purpose.
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_ThrowMethodAccessException")]
src/coreclr/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ThrowHelpers.cs:56
- [nitpick] The method name 'ThrowFieldAccessExceptionInternal' is ambiguous. It should be renamed to 'ThrowFieldAccessExceptionQCall' to better reflect its purpose.
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_ThrowFieldAccessException")]
src/coreclr/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ThrowHelpers.cs:70
- [nitpick] The method name 'ThrowClassAccessExceptionInternal' is ambiguous. It should be renamed to 'ThrowClassAccessExceptionQCall' to better reflect its purpose.
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_ThrowClassAccessException")]
25 tasks
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Jan 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert JIT helpers that throw specific exceptions to QCalls:
JIT_ThrowMethodAccessExceptionJIT_ThrowFieldAccessExceptionJIT_ThrowClassAccessExceptionContributes to #95695