Convert JitHelper JIT_StrCns to QCall
#113674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR converts the JitHelper JIT_StrCns to a QCall implementation to remove the Helper Method Frame (HMF).
- Added a new QCall method (StrCnsInternal) using LibraryImport with QCall entry point.
- Introduced an internal StrCns method that calls StrCnsInternal and converts the returned pointer to a string.
Files not reviewed (11)
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/vm/appdomainnative.cpp: Language not supported
- src/coreclr/vm/appdomainnative.hpp: Language not supported
- src/coreclr/vm/ceeload.cpp: Language not supported
- src/coreclr/vm/ceeload.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/jitinterface.cpp: Language not supported
- src/coreclr/vm/jitinterface.h: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
- src/coreclr/vm/qcallentrypoints.cpp: Language not supported
src/coreclr/System.Private.CoreLib/src/System/String.CoreCLR.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @mangod9 |
25 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/coreclr/System.Private.CoreLib/src/System/String.CoreCLR.cs
Outdated
Show resolved
Hide resolved
davidwrighton
approved these changes
Mar 18, 2025
jkotas
reviewed
Mar 19, 2025
src/coreclr/System.Private.CoreLib/src/System/String.CoreCLR.cs
Outdated
Show resolved
Hide resolved
IDisposable
approved these changes
Mar 19, 2025
|
/ba-g Known failure - #113652 |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Helper Method Frame (HMF) by converting to QCall.