Fix LLC cache issue on Apple M1 #64576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the L3 cache issue we've found in #60166 but for macOS-arm64
It seems that since macOS 12.0, Apple added more entries for
sysctl(see #62832 (comment)). And it turns out the keys we were using report cache size for the "efficiency cores", not the performance ones. As the result,PAL_GetLogicalProcessorCacheSizeFromOSused to return4mbinstead of expected12mb.This change shows nice improvements for GC-bound benchmarks and should address #60616 (comment)
Results (Apple M1 mac mini):