[arm64] Accelerate HexConverter::EncodeToUtf16 #67192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging myself to review next week |
2 tasks
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue DetailsThis partially rewrites
|
|
@tannergooding PTAL, sorry for the delayed response |
|
LGTM minus the comment on the magic constant |
@tannergooding addressed, can you approve it please? |
tannergooding
approved these changes
Apr 16, 2022
This was referenced Apr 22, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially rewrites
HexConverter::EncodeToUtf16_Ssse3to work with crossplatVector128to cover arm64.Also, this PR removes scalar loop to process trailing elements and does it in SIMD.