More XARCH PUTARG_STK CQ improvements
#67400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIncluded: And also: The latter change is responsible for some pretty nice diffs for - vmovss xmm0, dword ptr [ebp+0CH]
- sub esp, 4
- vmovss dword ptr [esp], xmm0
- vmovss xmm0, dword ptr [ebp+08H]
- sub esp, 4
- vmovss dword ptr [esp], xmm0
- vmovss xmm0, dword ptr [ebp+10H]
- sub esp, 4
- vmovss dword ptr [esp], xmm0
+ push dword ptr [ebp+0CH]
+ push dword ptr [ebp+08H]
+ push dword ptr [ebp+10H]
|
SingleAccretion
force-pushed
the
PutargStk-Primitives-Containment
branch
2 times, most recently
from
13e269a to
3f00262
Compare
The primary benefit of this change is "free" support for complex addressing modes, which is always desirable when we are loading a primitive (as opposed to the large struct case, where we would not want to use the 3-operand LEA in a loop, but instead cache the address in a register). The additional (future) benefit is that we will no longer need to mark the source local as DNER, once LCL_VAR sources for struct PUTARG_STKs are supported.
SingleAccretion
force-pushed
the
PutargStk-Primitives-Containment
branch
from
3f00262 to
db08d4d
Compare
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
Apr 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included:
And also:
The latter change is responsible for some pretty nice x86 diffs for
TYP_FLOATsources:We are expecting good improvements, with a few regressions due to different RA choices.
There were too many x86 diffs for SPMI in CI, plus there is an SPMI outage, so here is the full locally obtained version: win-x86.
Highlights: