vm: Improve getStringLiteral for dynamic context #68055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsImprove Closes #67956
|
EgorBo
commented
Apr 15, 2022
jkotas
reviewed
Apr 15, 2022
jkotas
reviewed
Apr 15, 2022
jkotas
reviewed
Apr 15, 2022
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
am11
reviewed
Apr 15, 2022
|
@jkotas @MichalStrehovsky does it look good now? |
jkotas
reviewed
Apr 15, 2022
jkotas
reviewed
Apr 15, 2022
jkotas
reviewed
Apr 15, 2022
jkotas
reviewed
Apr 16, 2022
jkotas
reviewed
Apr 16, 2022
jkotas
reviewed
Apr 16, 2022
jkotas
reviewed
Apr 16, 2022
|
LGTM otherwise |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Apr 16, 2022
jkotas
reviewed
Apr 16, 2022
jkotas
reviewed
Apr 16, 2022
jkotas
approved these changes
Apr 16, 2022
Closed
This was referenced Apr 22, 2022
|
Windows x86 improvements: dotnet/perf-autofiling-issues#4712 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
getStringLiteralAPI to return string content for dynamic context.Closes #67956
Fixes perf regression - #65222 (comment)