avoid allocationg ApplicationProtocol in common case #69098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailscontributes to #68951
|
davidfowl
reviewed
May 10, 2022
src/libraries/System.Net.Security/src/System/Net/Security/SslConnectionInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 10, 2022
src/libraries/Common/src/Interop/Windows/SChannel/Interop.SecPkgContext_ApplicationProtocol.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 10, 2022
| alpnContext.ProtoNegoStatus == Interop.ApplicationProtocolNegotiationStatus.Success) | ||
| { | ||
| return alpnContext.Protocol; | ||
| if (alpnContext.ProtocolIdSize == s_http1.Length && alpnContext.Protocol.SequenceEqual(s_http1)) |
There was a problem hiding this comment.
Why does the Windows one check ProtocolIdSize but the Linux one doesn't?
There was a problem hiding this comment.
The code originally looked different and I did not want to allocate the Span unless we need to. Perhaps that is cheap. Here I have the size available directly so I left the check in place. On Linux, The Interop function returns always Span so the code is somewhat different. I can remove the extra check if we want to.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #68951
For now, I updated Linux & Windows. Other platforms may be possible.