Fix FOH for SOS #76586
Merged
Fix FOH for SOS #76586
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @jkotas |
jkotas
reviewed
Oct 4, 2022
jkotas
reviewed
Oct 4, 2022
EgorBo
commented
Oct 4, 2022
jkotas
reviewed
Oct 4, 2022
|
Pri0 failure is #76280 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76232
The issue that FOH reported
sizeof(ObjHeader)-bytes less than needed inUpdateFrozenSegment. It used to report the actual end of the last object while it's expected to be actual end +sizeof(ObjHeader)(for next object)Tested locally with LLDB + SOS that it no longer printing errors.