KEMBAR78
fuse < and > with = when applicable by pedrobsaila · Pull Request #78786 · dotnet/runtime · GitHub
Skip to content

fuse < and > with = when applicable #78786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 10, 2023
Merged

fuse < and > with = when applicable #78786

merged 13 commits into from
Jun 10, 2023
+620 −36

Conversation

@pedrobsaila
Copy link
Contributor

Fixes #78385

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Nov 23, 2022
@ghost
Copy link

ghost commented Nov 23, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78385

Author: pedrobsaila
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall BruceForstall requested a review from EgorBo December 19, 2022 18:40
@BruceForstall
Copy link
Contributor

@EgorBo PTAL
cc @dotnet/jit-contrib

@EgorBo
Copy link
Member

EgorBo commented Jan 9, 2023

@pedrobsaila could you please merge/rebase recent Main into your PR so we can get the recent diffs?

@stephentoub stephentoub mentioned this pull request Jan 9, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Jan 10, 2023
Closed
@EgorBo
Copy link
Member

EgorBo commented Feb 6, 2023

/azp run Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member

EgorBo commented Mar 6, 2023

@pedrobsaila sorry for the delay, overall looks good to me, can you rebase it once again please?

@pedrobsaila
Copy link
Contributor Author

/azp run Fuzzlyn

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 78786 in repo dotnet/runtime

@JulieLeeMSFT
Copy link
Member

Ping @EgorBo for one more review.

@JulieLeeMSFT
Copy link
Member

@pedrobsaila, please resolve the conflict.

EgorBo

This comment was marked as duplicate.

Sign in to view

EgorBo
EgorBo approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay - LGTM, I see that we can check LCL_VAR by its num here since both blocks are expected to be single-statement and there should be no COMMAs or other ways to modify the value (in the common case, just checking numbers doesn't mean they're the same). I think it's good as is, but I'll file a PR to clean up this phase a bit, e.g. move these rules to a sort of macros-based table

@AndyAyersMS
Copy link
Member

@EgorBo should we merge this?

@EgorBo EgorBo merged commit eb786d5 into dotnet:main Jun 10, 2023
@pedrobsaila pedrobsaila deleted the 78385 branch June 10, 2023 12:45
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Jul 5, 2023
Closed
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@EgorBo EgorBo

@pedrobsaila pedrobsaila

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Numerical < and == comparisons aren't fused into <=

5 participants

@pedrobsaila @BruceForstall @EgorBo @JulieLeeMSFT @AndyAyersMS