Remove pointer relocs from GC statics #78794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFor every type with a GC static base (i.e. something with static fields that contain references to the GC heap) we are generating a small data structure that has up to two pointers in it:
These pointers can be relative pointers, so I'm doing that. Saves about 2 kB on a hello world on Windows. The savings will be closer to 0.5% on Linux due to getting rid of the full pointers (each costs extra 24 bytes on Linux). Cc @dotnet/ilc-contrib
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every type with a GC static base (i.e. something with static fields that contain references to the GC heap) we are generating a small data structure that has up to two pointers in it:
MethodTablethat is used to allocate the static base on the GC heap (and assists in reporting GC pointers within that data)..cctorand gets memcopied to the GC static base at startupThese pointers can be relative pointers, so I'm doing that. Saves about 2 kB on a hello world on Windows. The savings will be closer to 0.5% on Linux due to getting rid of the full pointers (each costs extra 24 bytes on Linux).
Cc @dotnet/ilc-contrib