[wasm] Fix debugger tests run on CI/Windows #79124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke recently:
```
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
D:\a\_work\1\s\src\mono\wasm\debugger\DebuggerTestSuite\DebuggerTestSuite.csproj(57,5): error MSB3073: The command "C:\Program Files\dotnet\dotnet.exe test --no-build -s D:\a\_work\1\s\artifacts\bin\DebuggerTestSuite\x64\Debug\.runsettings -t --nologo -v:q" exited with code 9009.
```
- this is breaking because we are running `src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj`
`<Exec Command="$(DotNetTool) test ..." />`
- and `DotNetTool` here is `c:\Program Files\dotnet\dotnet.exe`, and
the shell command breaks because of the space.
- this broke because recently we moved to building with `7.0.100`. And
when the version used for building matches the version installed on
the system, the system dotnet is used.
- but when it doesn't, it gets installed in
`</repo/checkout>/.dotnet/dotnet`
- So, because of the recent update the path changed to `C:\Program files`,
and broke the command.
- The fix is to simply quote the path.
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis broke recently, and can be see on a rolling build:
|
radical
changed the title
stephentoub
approved these changes
Dec 2, 2022
|
Merging to unblock CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke recently, and can be see on a rolling build:
this is breaking because we are running
src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj<Exec Command="$(DotNetTool) test ..." />DotNetToolhere isc:\Program Files\dotnet\dotnet.exe, and the shell command breaks because of the space.7.0.100. And when the version used for building matches the version installed on the system, the system dotnet is used.</repo/checkout>/.dotnet/dotnetC:\Program files, and broke the command. - The fix is to simply quote the path.