KEMBAR78
Only allocate StringBuilder for complex type names by benaadams · Pull Request #79325 · dotnet/runtime · GitHub
Skip to content

Only allocate StringBuilder for complex type names #79325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2022
Merged

Only allocate StringBuilder for complex type names #79325

merged 4 commits into from
Dec 7, 2022

Conversation

@benaadams
Copy link
Member

Resolves #79317

@ghost
Copy link

ghost commented Dec 7, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 7, 2022
@benaadams benaadams mentioned this pull request Dec 7, 2022
Closed
stephentoub
stephentoub approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. And nice to see you again :)

@benaadams @stephentoub
Update src/libraries/Common/src/Extensions/TypeNameHelper/TypeNameHel…
2d8adf8 
…per.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@benaadams
Copy link
Member Author

Thanks. And nice to see you again :)

My allocation senses were tingling 😅

@marek-safar marek-safar merged commit a2fb6e2 into dotnet:main Dec 7, 2022
@benaadams benaadams deleted the Only-allocate-StringBuilder-for-complex-type-names branch December 7, 2022 08:54
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logger name allocations from ILoggerFactory.CreateLogger<MyClass>()

3 participants

@benaadams @stephentoub @marek-safar