Enable CA1859 - Use concrete types when possible for improved performance #80848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
reviewed
Jan 19, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Internal/NativeFormat/NativeFormatWriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ExpressionTreeCallRewriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/BlockExpression.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.HttpListener/src/System/Net/WebSockets/HttpListenerWebSocketContext.cs
Outdated
Show resolved
Hide resolved
marek-safar
requested review from
MichalStrehovsky,
lewing,
pavelsavara,
radical and
thaystg
as code owners
marek-safar
force-pushed
the
analyzers
branch
from
bc1736b to
982c24d
Compare
marek-safar
force-pushed
the
analyzers
branch
from
7f07ef3 to
276f03b
Compare
This was referenced Jan 24, 2023
|
@stephentoub could you review it? |
stephentoub
reviewed
Jan 30, 2023
| } | ||
| } | ||
|
|
||
| #if NETCOREAPP2_1_OR_GREATER |
There was a problem hiding this comment.
Not related to your PR, but this is a strange choice of a compilation constant... Stream.ReadExactly was added in .NET 7, not .NET Core 2.1.
stephentoub
reviewed
Jan 30, 2023
stephentoub
reviewed
Jan 30, 2023
src/libraries/System.Net.Http/src/System/Net/Http/Headers/CacheControlHeaderValue.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2023
src/libraries/System.Transactions.Local/src/System.Transactions.Local.csproj
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 30, 2023
marek-safar
force-pushed
the
analyzers
branch
from
2883548 to
a00d4a0
Compare
marek-safar
force-pushed
the
analyzers
branch
from
a00d4a0 to
8587541
Compare
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stephentoub