avoid allocation of SelectClientCertificate delegate #81096
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThis change takes certificate selection from PAL and moves it back to main SslStream. Since we need (at the moment) some state information we pass the instance delegate. The logic is wrapped into new PAL method that can indicate that the update was successful (macOS & Linux) or if new credentials are needed (Windows) I also removed some logic from SelectClientCertificate() as it should not need to worry about the handshake state. The contributes to #68951 Testing: the select
|
ghost
locked as resolved and limited conversation to collaborators
2 participants
This change takes certificate selection from PAL and moves it back to main SslStream. Since we need (at the moment) some state information we pass the instance delegate. The logic is wrapped into new PAL method that can indicate that the update was successful (macOS & Linux) or if new credentials are needed (Windows)
I also removed some logic from SelectClientCertificate() as it should not need to worry about the handshake state. The
_credentialsHandlecan be `null on Unix so the logic seems suspicious anyway. Instead, the information is passed to 'AcquireClientCredentials' based on returned status code.contributes to #68951
Testing: the select
SelectClientCertificate no longe shows in allocation list